football2801/planeMapper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Review story 1.5: provisioning execution passes all ACs — Epic 1 complete

Browse Source 
Fix portal.py error handling so validate_cache failures return retry HTML while
kill_wifi ProvisioningError propagates (re-raise) per AC4. All 56 tests pass.
Update sprint-status.yaml: 1-5 → done, epic-1 → done. Append story 1.5 deferred
items to deferred-work.md.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Matt Edholm
2026-04-22 22:57:55 -04:00
parent 4aeeefb488
commit 9c53ccb524
4 changed files with 55 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/planemapper/provisioning/portal.py
+22 -21
View File
@@ -110,32 +110,33 @@ def _run_provisioning(
wifi_ssid: str,
wifi_password: str,
) -> str:
wifi.join_home_wifi(wifi_ssid, wifi_password)
tiles.download_and_composite(confirmed_lat, confirmed_lon, radius)
airspace.download(confirmed_lat, confirmed_lon, radius)
try:
wifi.join_home_wifi(wifi_ssid, wifi_password)
tiles.download_and_composite(confirmed_lat, confirmed_lon, radius)
airspace.download(confirmed_lat, confirmed_lon, radius)
tiles.validate_cache()
config.write(
{
"home_lat": confirmed_lat,
"home_lon": confirmed_lon,
"coverage_radius_nm": int(radius),
"wifi_ssid": wifi_ssid,
"wifi_password": wifi_password,
"provisioned": True,
}
)
wifi.kill_wifi()
return (
"<html><body>"
"<h1>Setup complete. The device will now start displaying radar.</h1>"
"</body></html>"
)
except ProvisioningError as e:
log.error("provisioning failed: %s", e)
log.error("cache validation failed: %s", e)
return (
f"<html><body><p>Provisioning failed: {e}. <a href='/'>Try again</a></p></body></html>"
f"<html><body><p>Cache validation failed: {e}. "
f"<a href='/'>Try again</a></p></body></html>"
)
config.write(
{
"home_lat": confirmed_lat,
"home_lon": confirmed_lon,
"coverage_radius_nm": int(radius),
"wifi_ssid": wifi_ssid,
"wifi_password": wifi_password,
"provisioned": True,
}
)
wifi.kill_wifi()
return (
"<html><body>"
"<h1>Setup complete. The device will now start displaying radar.</h1>"
"</body></html>"
)
@app.route("/submit", methods=["POST"])