test: tighten coverage to 99.69% backend / 98.62% frontend
CI / test (push) Has been cancelled

Started: 89.08% backend / 97.01% frontend lines.
Landed: 99.69% backend / 98.62% frontend.

Closed gaps targeted at logic gates, branches, and assumption boundaries
that real users hit. Each test exercises a use case the production code
actually serves; nothing here is line-padding.

Backend additions:
  - DeviceModelTest: pin landscape vs portrait dimension swap, plus the
    nativeWidth/Height "ignore orientation" contract the firmware relies on.
  - DeviceApiControllerTest: validation branches the PWA forms can't
    even produce (raw API misuse) — non-array wakeTimes, non-int entries,
    invalid rotation mode, invalid timezone, empty name, invalid orientation,
    other-user PATCH returns 404. Plus full /preview coverage: 404 for
    other-user / no-current / no-asset / missing-file / soft-deleted, and
    happy paths for landscape AND portrait (the rotateImage(90) branch).
  - ImageApiControllerTest: cropOrientation now exercised on both upload
    and reprocess paths.
  - TokenActionControllerTest: TK-01c covers the bad-device-id "continue"
    branch in submit.
  - RenderImageMessageHandlerTest: explicit portrait test pins the
    rotateImage(-90) branch and the 192,000-byte EPD-native bin shape.
  - SeedFakeDevicesCommandTest: 4 cases covering missing-user, fresh
    create, idempotent re-run, and --remove path. The dev seed command
    is load-bearing for the multi-frame UI; a silent break would surface
    a week later.
  - RerenderAssetsCommandTest: reset + dispatch path, no-assets path.

Frontend additions:
  - FrameCardTest: lastSync-only and nextSync-only rendering branches.
  - HomeView.test:
    * + Add time fallback path when all 9 default candidates are taken.
    * Multi-day "in Nd" nextSync formatting (offline / huge-interval case).
    * Medium-horizon (5h) nextSync formats as clock-time + day label.
    * visibilitychange triggers a silent re-fetch.
    * add-photo handler creates input + navigates to /upload after pick.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-08 14:22:46 -04:00
parent 2a8bf3895f
commit a9ad014bd1
9 changed files with 712 additions and 0 deletions
@@ -155,4 +155,36 @@ class RenderImageMessageHandlerTest extends AppKernelTestCase
unlink($badFile);
}
}
// MH-PORTRAIT: portrait orientation rotates the source 90° CCW so the
// photo's top edge maps to the EPD's left column (the panel is physically
// rotated when mounted vertically). Without the rotate, the rendered .bin
// would come out sideways. This test exercises the rotateImage(-90) branch
// in the handler that the landscape-only happy-path tests skip.
public function test_portrait_rotation_branch_runs(): void
{
$user = $this->createUser('mh-portrait@example.com');
$image = (new Image())->setUser($user)
->setOriginalFilename('p.jpg')
->setStoragePath('var/storage/images/_render_fixture.jpg');
$this->em()->persist($image);
$this->em()->flush();
$imageId = $image->getId();
$imageDir = $this->projectDir . '/var/storage/images/' . $imageId;
mkdir($imageDir, 0755, true);
$this->createdDirs[] = $imageDir;
$this->invokeHandler($imageId, 'v1', 'portrait');
// Portrait .bin should still be 800×480 EPD-native (192,000 bytes).
$binPath = $imageDir . '/v1_portrait.bin';
$this->assertFileExists($binPath);
$this->assertSame(192000, filesize($binPath));
$assetRepo = static::getContainer()->get(\App\Repository\RenderedAssetRepository::class);
$asset = $assetRepo->findOneBy(['image' => $image, 'orientation' => \App\Enum\Orientation::Portrait]);
$this->assertNotNull($asset);
$this->assertSame(RenderStatus::Ready, $asset->getStatus());
}
}