Started: 89.08% backend / 97.01% frontend lines.
Landed: 99.69% backend / 98.62% frontend.
Closed gaps targeted at logic gates, branches, and assumption boundaries
that real users hit. Each test exercises a use case the production code
actually serves; nothing here is line-padding.
Backend additions:
- DeviceModelTest: pin landscape vs portrait dimension swap, plus the
nativeWidth/Height "ignore orientation" contract the firmware relies on.
- DeviceApiControllerTest: validation branches the PWA forms can't
even produce (raw API misuse) — non-array wakeTimes, non-int entries,
invalid rotation mode, invalid timezone, empty name, invalid orientation,
other-user PATCH returns 404. Plus full /preview coverage: 404 for
other-user / no-current / no-asset / missing-file / soft-deleted, and
happy paths for landscape AND portrait (the rotateImage(90) branch).
- ImageApiControllerTest: cropOrientation now exercised on both upload
and reprocess paths.
- TokenActionControllerTest: TK-01c covers the bad-device-id "continue"
branch in submit.
- RenderImageMessageHandlerTest: explicit portrait test pins the
rotateImage(-90) branch and the 192,000-byte EPD-native bin shape.
- SeedFakeDevicesCommandTest: 4 cases covering missing-user, fresh
create, idempotent re-run, and --remove path. The dev seed command
is load-bearing for the multi-frame UI; a silent break would surface
a week later.
- RerenderAssetsCommandTest: reset + dispatch path, no-assets path.
Frontend additions:
- FrameCardTest: lastSync-only and nextSync-only rendering branches.
- HomeView.test:
* + Add time fallback path when all 9 default candidates are taken.
* Multi-day "in Nd" nextSync formatting (offline / huge-interval case).
* Medium-horizon (5h) nextSync formats as clock-time + day label.
* visibilitychange triggers a silent re-fetch.
* add-photo handler creates input + navigates to /upload after pick.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -429,6 +429,7 @@ class ImageApiControllerTest extends AppWebTestCase
|
||||
$client->request('POST', '/api/images', [
|
||||
'cropParams' => '{"x":0,"y":0,"w":100,"h":100}',
|
||||
'stickerState' => '{"stickers":[]}',
|
||||
'cropOrientation' => 'portrait',
|
||||
], [
|
||||
'file' => $this->makeUploadedFile(),
|
||||
]);
|
||||
@@ -437,6 +438,7 @@ class ImageApiControllerTest extends AppWebTestCase
|
||||
$data = json_decode($client->getResponse()->getContent(), true);
|
||||
$this->assertNotNull($data['cropParams']);
|
||||
$this->assertNotNull($data['stickerState']);
|
||||
$this->assertSame('portrait', $data['cropOrientation']);
|
||||
}
|
||||
|
||||
public function test_original_returns_404_when_no_file_on_disk(): void
|
||||
@@ -488,6 +490,7 @@ class ImageApiControllerTest extends AppWebTestCase
|
||||
$client->request('POST', '/api/images/' . $imageId . '/reprocess', [
|
||||
'cropParams' => '{"x":10,"y":10}',
|
||||
'stickerState' => '{"stickers":[]}',
|
||||
'cropOrientation' => 'landscape',
|
||||
], [
|
||||
'file' => $this->makeUploadedFile(),
|
||||
]);
|
||||
@@ -496,6 +499,7 @@ class ImageApiControllerTest extends AppWebTestCase
|
||||
$data = json_decode($client->getResponse()->getContent(), true);
|
||||
$this->assertNotNull($data['cropParams']);
|
||||
$this->assertNotNull($data['stickerState']);
|
||||
$this->assertSame('landscape', $data['cropOrientation']);
|
||||
}
|
||||
|
||||
public function test_share_with_self_returns_422(): void
|
||||
|
||||
Reference in New Issue
Block a user