chore(dev): DDEV setup so the test suite actually runs
CI / test (push) Has been cancelled

Mirrors aqua-iq's pattern but adapted for pictureFrame's stack:
postgres 16, php 8.4, node 22, imagick + pcov via apt extras,
Mercure hub at https://pictureframe.ddev.site/.well-known/mercure,
and four custom commands — `ddev tests`, `ddev coverage`,
`ddev frontend` (vite HMR), `ddev worker`.

Also restores dev deps (DAMA, Doctrine fixtures, symfony/uid) that
got dropped during earlier composer reshuffles, and adds a separate
`db_test` connection in .env.test so DAMA's transactional isolation
doesn't share state with whatever dev is mid-experiment with.

Two test fixes the new env exposed:
  - RotationServiceTest::test_prioritize_never_shown_falls_through_when_all_shown
    needed uniquenessWindow=2 so the recent-window filter wipes the
    set and the fallback restores the full pool — otherwise window=1
    excluded the most-recently-served image and the assertion drifted.
  - DeviceImageControllerTest::test_locked_image_served_without_rotation_advance
    was asserting currentImage stays null on a lock poll, but the
    controller intentionally sets currentImage on the lock path so
    Home reflects the live frame state. Now asserts both the
    currentImage update AND that no DeviceImageHistory row was
    written (the actual rotation-bypass guarantee).

Backend coverage (full suite via `ddev coverage`): 89.08% lines /
92.24% methods / 74.36% classes — the first real number we've had.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-08 13:56:36 -04:00
parent b48ed73b4e
commit 2a8bf3895f
14 changed files with 602 additions and 13 deletions
+9 -3
View File
@@ -480,7 +480,11 @@ class RotationServiceTest extends AppKernelTestCase
}
// RM-06: prioritizeNeverShown is a no-op when no never-shown images
// remain — falls through to the mode.
// remain — falls through to the mode. Uses a uniquenessWindow large
// enough that the recent-window filter wipes the candidate set and the
// fallback restores the full pool, otherwise window=1 would exclude the
// most-recently-served image and the mode-picks-from-2 assertion is
// testing the wrong axis.
public function test_prioritize_never_shown_falls_through_when_all_shown(): void
{
[$device, $images] = $this->setupDeviceAndImages('prio-fall@example.com', [
@@ -488,10 +492,12 @@ class RotationServiceTest extends AppKernelTestCase
]);
$device->setRotationMode(RotationMode::NewestUpload);
$device->setPrioritizeNeverShown(true);
$device->setUniquenessWindow(1);
$device->setUniquenessWindow(2);
self::em()->flush();
// Both shown — never-shown set is empty, so mode (NewestUpload) takes over.
// Both shown — never-shown set is empty, so mode (NewestUpload) takes
// over. Window=2 wipes both via the recent filter and the fallback
// restores the full pool, so the mode genuinely chooses between both.
$this->recordHistoryAt($device, $images[0], '2025-06-01');
$this->recordHistoryAt($device, $images[1], '2025-06-02');