Two related bugs that surfaced on the first 13.3" device's first photo: 1) Web-UI portrait preview was 90° sideways. DeviceApiController:: renderBinToPng rotated whenever the device was Portrait — correct for V1 (landscape-native, Portrait => renderer rotated, so preview un-rotates) but wrong for V2 (portrait-native — the renderer doesn't rotate, so the preview shouldn't either). Now mirrors the render-pipeline check: rotate only when `orientation !== model->nativeOrientation()`. Two new functional tests pin the V2 portrait and V2 landscape PNG dimensions to guard against regressions. 2) Cropped photo letterboxed on the 13.3" panel. CropEditor / StickerCanvas / FrameCard had V1 dimensions hardcoded (1600×960 = 5:3 aspect). V2 is 4:3 (1200×1600 portrait / 1600×1200 landscape), so a "full crop" came out the wrong shape and the server's white-canvas composite added bars. New `panelDims(model, orientation)` helper in @/types is the single source of truth on the frontend; matches DeviceModel::width/height on the server. Threaded `model` through Device serializer → Device type → UploadView → CropEditor / StickerCanvas, and HomeView → FrameCard. FrameCard tests updated to cover all four model × orientation placeholders. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -34,7 +34,7 @@ class DeviceSerializerTest extends TestCase
|
||||
$payload = $this->serializer->serialize($device);
|
||||
|
||||
$this->assertEqualsCanonicalizing(
|
||||
['id', 'mac', 'name', 'orientation', 'rotationIntervalMinutes',
|
||||
['id', 'mac', 'name', 'model', 'orientation', 'rotationIntervalMinutes',
|
||||
'wakeTimes', 'timezone', 'uniquenessWindow', 'rotationMode',
|
||||
'prioritizeNeverShown', 'linkedAt', 'lastSeenAt',
|
||||
'nextPollExpectedAt', 'lockedImageId', 'currentImageId'],
|
||||
@@ -42,6 +42,14 @@ class DeviceSerializerTest extends TestCase
|
||||
);
|
||||
}
|
||||
|
||||
public function test_serializes_model_field(): void
|
||||
{
|
||||
$device = $this->makeDevice();
|
||||
$device->setModel(\App\Enum\DeviceModel::V2);
|
||||
$payload = $this->serializer->serialize($device);
|
||||
$this->assertSame('v2', $payload['model']);
|
||||
}
|
||||
|
||||
public function test_serializes_scalars_in_expected_shapes(): void
|
||||
{
|
||||
$device = $this->makeDevice();
|
||||
|
||||
Reference in New Issue
Block a user